This repository was archived by the owner on Jan 16, 2022. It is now read-only.
feat: updated typescript to 3.5.2#91
Merged
juanpicado merged 2 commits intoverdaccio:4.x-masterfrom Jul 9, 2019
tmkn:feat/update_typescript
Merged
feat: updated typescript to 3.5.2#91juanpicado merged 2 commits intoverdaccio:4.x-masterfrom tmkn:feat/update_typescript
juanpicado merged 2 commits intoverdaccio:4.x-masterfrom
tmkn:feat/update_typescript
Conversation
juanpicado
reviewed
Jul 8, 2019
juanpicado
suggested changes
Jul 8, 2019
Member
juanpicado
left a comment
juanpicado
left a comment
There was a problem hiding this comment.
Good start 👍 , but require your input before moving forward. Check above please.
Member
|
For this PR I'd rather use the commit message |
Member
|
@priscilawebdev do you see any conflict with Material-UI migration using the latest TS version? |
sergiohgz
suggested changes
Jul 8, 2019
Contributor
sergiohgz
left a comment
sergiohgz
left a comment
There was a problem hiding this comment.
I don't understand why we need to remove the token from App, it's necessary in the client
juanpicado
approved these changes
Jul 8, 2019
sergiohgz
approved these changes
Jul 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type:
The following has been addressed in the PR:
Description:
This increases the version of TypeScript to 3.5.2
Due to the improved type checking some adaptions were necessary
Tests have been adapted