This repository was archived by the owner on Jan 16, 2022. It is now read-only.
Merged
Conversation
- Remove unnecessary quotes in Emotion css templated string - Revert md prop removed in #47 (with the size set before that)
priscilawebdev
previously approved these changes
Jul 9, 2019
Contributor
|
@sergiohgz Thank you!! |
griffithtp
reviewed
Jul 9, 2019
…t-logos-style # Conflicts: # src/components/Login/__snapshots__/Login.test.tsx.snap
juanpicado
suggested changes
Jul 10, 2019
Codecov Report
@@ Coverage Diff @@
## 4.x-master #94 +/- ##
==============================================
+ Coverage 70.21% 70.27% +0.06%
==============================================
Files 89 89
Lines 856 858 +2
Branches 155 141 -14
==============================================
+ Hits 601 603 +2
- Misses 243 246 +3
+ Partials 12 9 -3
Continue to review full report at Codecov.
|
juanpicado
approved these changes
Jul 10, 2019
Member
juanpicado
left a comment
juanpicado
left a comment
There was a problem hiding this comment.
Thanks @sergiohgz works fine, nice refactoring, much easier to understand what the prop does and easy to extend if we need it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: fix
The following has been addressed in the PR:
Description: This fixes the logo styles following next:
mdprop where removed from Logo component. After revert and set a bigger size whenmd(the same value before that PR), logo is centered and have correct styles.