Skip to content

Allow virtual props in embed lifts#4856

Draft
Cisphyx wants to merge 14 commits intosynapse-3xxfrom
allow-virt-embeds
Draft

Allow virtual props in embed lifts#4856
Cisphyx wants to merge 14 commits intosynapse-3xxfrom
allow-virt-embeds

Conversation

@Cisphyx
Copy link
Copy Markdown
Contributor

@Cisphyx Cisphyx commented Apr 3, 2026

No description provided.

@Cisphyx Cisphyx added this to the v3.0.0 milestone Apr 3, 2026
@Cisphyx Cisphyx changed the title Allow virt embeds Allow virtual props in embed lifts Apr 3, 2026
@Cisphyx Cisphyx marked this pull request as draft April 3, 2026 14:16
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.21%. Comparing base (f944110) to head (ff93aa1).
⚠️ Report is 21 commits behind head on synapse-3xx.

Files with missing lines Patch % Lines
synapse/lib/ast.py 41.66% 14 Missing ⚠️

❌ Your patch check has failed because the patch coverage (41.66%) is below the target coverage (97.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@               Coverage Diff               @@
##           synapse-3xx    #4856      +/-   ##
===============================================
- Coverage        96.23%   96.21%   -0.02%     
===============================================
  Files              259      259              
  Lines            63169    63189      +20     
===============================================
+ Hits             60788    60797       +9     
- Misses            2381     2392      +11     
Flag Coverage Δ
linux 96.21% <41.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from virt-overlap-cleanup to synapse-3xx April 3, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant