Add custom CA bundle support for downloads#235
Conversation
|
I investigated the ecosystem around cert. reqwest doesn't support it directly yet ( seanmonstar/reqwest#2159 ) How about using this scheme? |
|
Thank you for your suggestions and information! As you mentioned, since reqwest doesn’t currently support this directly, replacing the verifier on the application side is a valid approach. For now, I’ll adopt the same approach as rustup, and will consider migrating as reqwest progresses. |
|
Verified on my environment:
|
|
Thank you for your contribution! |
Summary
reqwest::ClientBuilderfromSSL_CERT_FILEor common CA bundle locations so thatverylup setupsucceeds in environments that require a custom root CA.Testing
cargo checkverylup setup(WSL2 / Arch Linux behind the proxy)Concern
SSL_CERT_FILEenvironment variable. Since verylup already has its own config file, would it make sense to allow specifying the CA certificate path there instead?Fixes #234