run clang-format in config modules#36440
Open
arnej27959 wants to merge 2 commits intomasterfrom
Open
Conversation
vekterli
reviewed
Apr 17, 2026
cab311c to
7395d12
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies clang-format across the config-related C++ modules and adjusts the config/.clang-format rules to match the desired formatting (line width, include ordering, and alignment/brace wrapping behavior).
Changes:
- Reformat C++ source and header files (brace wrapping, whitespace/alignment, and line wrapping).
- Regroup/reorder
#includeblocks to match updated include category rules. - Update
config/.clang-formatto reflect the formatting configuration used for these modules.
Reviewed changes
Copilot reviewed 117 out of 175 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| configutil/src/tests/model_inspect/model_inspect_test.cpp | clang-format: include ordering and whitespace/indentation |
| configutil/src/tests/config_status/config_status_test.cpp | clang-format: expand short functions and reflow formatting |
| configutil/src/lib/tags.h | clang-format: declaration alignment cleanup |
| configutil/src/lib/modelinspect.h | clang-format: declaration alignment cleanup |
| configutil/src/lib/modelinspect.cpp | clang-format: include regrouping and brace wrapping |
| configutil/src/lib/configstatus.cpp | clang-format: include regrouping |
| configutil/src/apps/modelinspect/main.cpp | clang-format: include regrouping and brace wrapping |
| configutil/src/apps/configstatus/main.cpp | clang-format: include regrouping and brace wrapping |
| configd/src/apps/sentinel/service.h | clang-format: member/function declaration formatting |
| configd/src/apps/sentinel/service.cpp | clang-format: include regrouping, brace wrapping, and line wrapping |
| configd/src/apps/sentinel/sentinel.cpp | clang-format: include ordering and expand short function |
| configd/src/apps/sentinel/rpcserver.h | clang-format: inline accessor formatting |
| configd/src/apps/sentinel/report-connectivity.h | clang-format: declaration formatting |
| configd/src/apps/sentinel/report-connectivity.cpp | clang-format: line wrapping |
| configd/src/apps/sentinel/peer-check.h | clang-format: inline accessor formatting |
| configd/src/apps/sentinel/outward-check.h | clang-format: method declaration formatting |
| configd/src/apps/sentinel/output-connection.h | clang-format: inline accessor formatting |
| configd/src/apps/sentinel/output-connection.cpp | clang-format: include regrouping and expand short functions |
| configd/src/apps/sentinel/model-owner.h | clang-format: method declaration formatting |
| configd/src/apps/sentinel/model-owner.cpp | clang-format: spacing/brace wrapping |
| configd/src/apps/sentinel/metrics.cpp | clang-format: line wrapping |
| configd/src/apps/sentinel/manager.h | clang-format: include regrouping and method declaration formatting |
| configd/src/apps/sentinel/manager.cpp | clang-format: include ordering and line wrapping |
| configd/src/apps/sentinel/logctl.cpp | clang-format: include ordering |
| configd/src/apps/sentinel/line-splitter.h | clang-format: inline accessor formatting |
| configd/src/apps/sentinel/line-splitter.cpp | clang-format: include ordering and expand short functions |
| configd/src/apps/sentinel/env.h | clang-format: accessor and private method declaration formatting |
| configd/src/apps/sentinel/connectivity.h | clang-format: method declaration formatting |
| configd/src/apps/sentinel/connectivity.cpp | clang-format: line wrapping |
| configd/src/apps/sentinel/config-owner.h | clang-format: method declaration formatting |
| configd/src/apps/sentinel/config-owner.cpp | clang-format: line wrapping across string literals |
| configd/src/apps/sentinel/cmdq.h | clang-format: inline accessor formatting |
| configd/src/apps/sentinel/cmdq.cpp | clang-format: expand short methods |
| configd/src/apps/sentinel/check-completion-handler.cpp | clang-format: expand short constructor |
| configd/src/apps/cmd/main.cpp | clang-format: method declaration formatting |
| config/src/vespa/config/subscription/sourcespec.h | clang-format: private method declarations |
| config/src/vespa/config/subscription/sourcespec.cpp | clang-format: expand short ctors and brace wrapping |
| config/src/vespa/config/subscription/configuri.cpp | clang-format: expand short methods/ctors |
| config/src/vespa/config/subscription/configsubscriptionset.cpp | clang-format: expand short ctor/dtor and line wrapping |
| config/src/vespa/config/subscription/configsubscription.h | clang-format: method declaration formatting |
| config/src/vespa/config/subscription/configsubscription.cpp | clang-format: expand short ctor/dtor/method |
| config/src/vespa/config/subscription/configsubscriber.cpp | clang-format: expand short methods and brace wrapping |
| config/src/vespa/config/subscription/confighandle.hpp | clang-format: expand short template methods |
| config/src/vespa/config/set/configsetsourcefactory.cpp | clang-format: expand short ctor |
| config/src/vespa/config/set/configsetsource.cpp | clang-format: expand short method |
| config/src/vespa/config/set/configinstancesourcefactory.cpp | clang-format: line wrapping and expand short ctor |
| config/src/vespa/config/retriever/simpleconfigurer.cpp | clang-format: expand short destructor |
| config/src/vespa/config/retriever/simpleconfigretriever.h | clang-format: method declaration formatting |
| config/src/vespa/config/retriever/simpleconfigretriever.cpp | clang-format: expand short methods |
| config/src/vespa/config/retriever/genericconfigsubscriber.h | clang-format: method declaration formatting |
| config/src/vespa/config/retriever/genericconfigsubscriber.cpp | clang-format: expand short methods |
| config/src/vespa/config/retriever/fixedconfigsubscriber.h | clang-format: method declaration formatting |
| config/src/vespa/config/retriever/fixedconfigsubscriber.cpp | clang-format: expand short methods |
| config/src/vespa/config/retriever/configsnapshot.h | clang-format: method declaration formatting |
| config/src/vespa/config/retriever/configsnapshot.cpp | clang-format: expand short methods/ctors |
| config/src/vespa/config/retriever/configretriever.h | clang-format: line wrapping in API declaration |
| config/src/vespa/config/retriever/configretriever.cpp | clang-format: expand short ctor and method |
| config/src/vespa/config/raw/rawsource.h | clang-format: member declaration formatting |
| config/src/vespa/config/raw/rawsource.cpp | clang-format: expand short methods |
| config/src/vespa/config/print/ostreamconfigwriter.cpp | clang-format: expand short methods |
| config/src/vespa/config/print/jsonconfigformatter.cpp | clang-format: expand short ctor |
| config/src/vespa/config/print/istreamconfigreader.hpp | clang-format: expand short template ctor |
| config/src/vespa/config/print/fileconfigwriter.cpp | clang-format: expand short methods |
| config/src/vespa/config/print/fileconfigsnapshotwriter.cpp | clang-format: expand short ctor |
| config/src/vespa/config/print/fileconfigsnapshotreader.cpp | clang-format: expand short ctor |
| config/src/vespa/config/print/fileconfigreader.hpp | clang-format: expand short template ctor |
| config/src/vespa/config/print/configdatabuffer.h | clang-format: accessor formatting |
| config/src/vespa/config/print/configdatabuffer.cpp | clang-format: expand short ctor/dtor |
| config/src/vespa/config/print/asciiconfigwriter.cpp | clang-format: expand short methods |
| config/src/vespa/config/print/asciiconfigsnapshotwriter.cpp | clang-format: expand short ctor |
| config/src/vespa/config/print/asciiconfigsnapshotreader.cpp | clang-format: expand short ctor |
| config/src/vespa/config/print/asciiconfigreader.hpp | clang-format: expand short template ctor |
| config/src/vespa/config/helper/legacysubscriber.h | clang-format: wrap long template declaration |
| config/src/vespa/config/helper/legacysubscriber.cpp | clang-format: expand short ctor/dtor |
| config/src/vespa/config/helper/legacy.h | clang-format: declaration formatting |
| config/src/vespa/config/helper/legacy.cpp | clang-format: expand short internal helpers |
| config/src/vespa/config/helper/ihandle.h | clang-format: typedef and method declaration formatting |
| config/src/vespa/config/helper/configpoller.h | clang-format: template/method declaration formatting |
| config/src/vespa/config/helper/configpoller.cpp | clang-format: expand short ctor and method |
| config/src/vespa/config/helper/configfetcher.h | clang-format: method declaration formatting |
| config/src/vespa/config/helper/configfetcher.cpp | clang-format: expand short ctors/dtor/method |
| config/src/vespa/config/frt/slimeconfigresponse.h | clang-format: accessor and private method declaration formatting |
| config/src/vespa/config/frt/slimeconfigresponse.cpp | clang-format: expand short ctor and line wrapping |
| config/src/vespa/config/frt/slimeconfigrequest.h | clang-format: member alignment and method declaration formatting |
| config/src/vespa/config/frt/slimeconfigrequest.cpp | clang-format: wrap long ctor signature |
| config/src/vespa/config/frt/protocol.h | clang-format: function declaration formatting |
| config/src/vespa/config/frt/protocol.cpp | clang-format: include ordering |
| config/src/vespa/config/frt/frtsourcefactory.cpp | clang-format: expand short ctor |
| config/src/vespa/config/frt/frtsource.h | clang-format: private method declaration formatting |
| config/src/vespa/config/frt/frtsource.cpp | clang-format: expand short dtor/method |
| config/src/vespa/config/frt/frtconnectionpool.h | clang-format: override method declaration formatting |
| config/src/vespa/config/frt/frtconnectionpool.cpp | clang-format: expand short methods and line wrapping |
| config/src/vespa/config/frt/frtconnection.h | clang-format: method declaration formatting |
| config/src/vespa/config/frt/frtconnection.cpp | clang-format: expand short ctor/method |
| config/src/vespa/config/frt/frtconfigresponsev3.h | clang-format: private method declaration formatting |
| config/src/vespa/config/frt/frtconfigresponsev3.cpp | clang-format: expand short methods |
| config/src/vespa/config/frt/frtconfigresponse.h | clang-format: public method declaration formatting |
| config/src/vespa/config/frt/frtconfigresponse.cpp | clang-format: expand short methods |
| config/src/vespa/config/frt/frtconfigrequestv3.cpp | clang-format: wrap long ctor signature and expand body |
| config/src/vespa/config/frt/frtconfigrequestfactory.cpp | clang-format: expand short ctor and wrap method signature |
| config/src/vespa/config/frt/frtconfigrequest.h | clang-format: method declaration formatting |
| config/src/vespa/config/frt/frtconfigrequest.cpp | clang-format: expand short methods |
| config/src/vespa/config/frt/frtconfigagent.h | clang-format: method declaration formatting |
| config/src/vespa/config/frt/frtconfigagent.cpp | clang-format: expand short ctor/accessors and wrap long call |
| config/src/vespa/config/frt/connectionfactory.h | clang-format: interface method formatting |
| config/src/vespa/config/frt/connection.h | clang-format: interface method formatting |
| config/src/vespa/config/frt/compressioninfo.h | clang-format: method declaration formatting |
| config/src/vespa/config/frt/compressioninfo.cpp | clang-format: expand short ctor |
| config/src/vespa/config/file_acquirer/file_acquirer.cpp | clang-format: expand short ctor |
| config/src/vespa/config/file/filesourcefactory.cpp | clang-format: expand short ctor |
| config/src/vespa/config/file/filesource.h | clang-format: method declaration formatting |
| config/src/vespa/config/file/filesource.cpp | clang-format: expand short ctor/methods |
| config/src/vespa/config/configgen/vector_inserter.hpp | clang-format: expand short template ctor |
| config/src/vespa/config/configgen/value_converter.cpp | clang-format: line wrapping |
| config/src/vespa/config/configgen/map_inserter.hpp | clang-format: expand short template ctor and line wrapping |
| config/src/vespa/config/common/vespa_version.h | clang-format: method declaration formatting |
| config/src/vespa/config/common/vespa_version.cpp | clang-format: expand short methods |
| config/src/vespa/config/common/trace.h | clang-format: method declaration formatting |
| config/src/vespa/config/common/trace.cpp | clang-format: expand short ctors and method |
| config/src/vespa/config/common/timingvalues.h | clang-format: line wrapping |
| config/src/vespa/config/common/timingvalues.cpp | clang-format: expand short ctors |
| config/src/vespa/config/common/sourcefactory.h | clang-format: wrap long pure-virtual declaration |
| config/src/vespa/config/common/payload_converter.h | clang-format: method declaration formatting |
| config/src/vespa/config/common/payload_converter.cpp | clang-format: expand short methods |
| config/src/vespa/config/common/misc.cpp | clang-format: include ordering and expand short function |
| config/src/vespa/config/common/iconfigholder.h | clang-format: method declaration formatting |
| config/src/vespa/config/common/configvalue.h | clang-format: accessor and method declaration formatting |
| config/src/vespa/config/common/configvalue.cpp | clang-format: expand short ctors/operators |
| config/src/vespa/config/common/configupdate.h | clang-format: accessor and inline method formatting |
| config/src/vespa/config/common/configupdate.cpp | clang-format: expand short ctor |
| config/src/vespa/config/common/configsystem.h | clang-format: private method declaration formatting |
| config/src/vespa/config/common/configsystem.cpp | clang-format: expand short helpers/methods |
| config/src/vespa/config/common/configresponse.h | clang-format: interface method formatting |
| config/src/vespa/config/common/configparser.h | clang-format: method formatting and wrap long declarations |
| config/src/vespa/config/common/configmanager.h | clang-format: method declaration formatting |
| config/src/vespa/config/common/configmanager.cpp | clang-format: expand short ctor and line wrapping |
| config/src/vespa/config/common/configkey.h | clang-format: accessor declarations formatting |
| config/src/vespa/config/common/configkey.cpp | clang-format: expand short methods/operators/accessors |
| config/src/vespa/config/common/configholder.h | clang-format: method declaration formatting |
| config/src/vespa/config/common/configholder.cpp | clang-format: expand short ctor |
| config/src/vespa/config/common/configdefinition.h | clang-format: method declaration formatting |
| config/src/vespa/config/common/configdefinition.cpp | clang-format: expand short ctors |
| config/src/vespa/config/common/configcontext.h | clang-format: method declaration formatting |
| config/src/vespa/config/common/configcontext.cpp | clang-format: expand short methods/ctors |
| config/src/vespa/config/common/compressiontype.h | clang-format: function declaration formatting |
| config/src/tests/unittest/unittest.cpp | clang-format: include ordering/regrouping |
| config/src/tests/subscription/subscription_test.cpp | clang-format: expand helper function |
| config/src/tests/subscriber/subscriber_test.cpp | clang-format: include regrouping and expand helpers |
| config/src/tests/raw_subscription/raw_subscription_test.cpp | clang-format: include ordering |
| config/src/tests/print/print_test.cpp | clang-format: include regrouping |
| config/src/tests/misc/configsystem_test.cpp | clang-format: include ordering |
| config/src/tests/legacysubscriber/legacysubscriber_test.cpp | clang-format: include ordering |
| config/src/tests/getconfig/getconfig_test.cpp | clang-format: include ordering |
| config/src/tests/functiontest/functiontest.cpp | clang-format: include ordering and expand fixture ctor/dtor |
| config/src/tests/frtconnectionpool/frtconnectionpool.cpp | clang-format: include ordering and expand dtor |
| config/src/tests/frt/frt_test.cpp | clang-format: include ordering and method formatting |
| config/src/tests/file_subscription/file_subscription_test.cpp | clang-format: include ordering |
| config/src/tests/file_acquirer/file_acquirer_test.cpp | clang-format: expand short dtor |
| config/src/tests/failover/failover_test.cpp | clang-format: include ordering and wrap ctor |
| config/src/tests/configuri/configuri_test.cpp | clang-format: include ordering and expand helper |
| config/src/tests/configretriever/configretriever_test.cpp | clang-format: include ordering and expand fixture ctor/dtor |
| config/src/tests/configmanager/configmanager_test.cpp | clang-format: expand inline method and fixture ctor/dtor |
| config/src/tests/configgen/vector_inserter_test.cpp | clang-format: include ordering |
| config/src/tests/configgen/map_inserter_test.cpp | clang-format: include ordering |
| config/src/tests/configgen/configgen_test.cpp | clang-format: include ordering |
| config/src/tests/configfetcher/configfetcher_test.cpp | clang-format: include ordering and expand ctor |
| config/src/tests/configagent/configagent_test.cpp | clang-format: method/member declaration formatting |
| config/src/tests/api/api.cpp | clang-format: include ordering |
| config/src/apps/vespa-ping-configproxy/pingproxy.cpp | clang-format: include ordering and method declaration formatting |
| config/src/apps/vespa-get-config/getconfig.cpp | clang-format: include ordering and method declaration formatting |
| config/src/apps/vespa-configproxy-cmd/proxycmd.h | clang-format: pointer spacing and method declaration formatting |
| config/src/apps/vespa-configproxy-cmd/proxycmd.cpp | clang-format: expand short ctors |
| config/src/apps/vespa-configproxy-cmd/methods.h | clang-format: function declaration formatting |
| config/src/apps/vespa-configproxy-cmd/main.cpp | clang-format: include ordering and method declaration formatting |
| config/.clang-format | update clang-format rules (column limit, include categories, alignment options) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.