Skip to content

support sharded graphite using metrics/expand instead of index.json#80

Closed
nikicat wants to merge 1 commit intovimeo:masterfrom
nikicat:master
Closed

support sharded graphite using metrics/expand instead of index.json#80
nikicat wants to merge 1 commit intovimeo:masterfrom
nikicat:master

Conversation

@nikicat
Copy link
Copy Markdown

@nikicat nikicat commented Dec 23, 2013

Review on Reviewable

@Dieterbe
Copy link
Copy Markdown
Contributor

Dieterbe commented Apr 7, 2014

looks like we should use graphite-project/graphite-web#329

tarnfeld added a commit to tarnfeld/graph-explorer that referenced this pull request Jul 8, 2014
@Dieterbe
Copy link
Copy Markdown
Contributor

Dieterbe commented Aug 8, 2014

so graphite-project/graphite-web#550 was never merged,
but graphite-project/graphite-web#329 is

I think the only thing we should do is request index.json?cluster=1 instead of just index.json

@deejay1
Copy link
Copy Markdown

deejay1 commented Feb 7, 2015

index.json?cluster=1 is not supported in all infrastructure types, IMHO there should be a fallback if index.json returns [ ] for discovery using metrics/find or metrics/expand as at least the first one works at our setup (I haven't checked the second one yet)

@Dieterbe
Copy link
Copy Markdown
Contributor

can you explain in which cases index.json?cluster=1 works and in which it doesn't?

@nikicat nikicat closed this Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants