Consistent division and modulo#448
Merged
Merged
Conversation
…sistent with the SMT division).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Carbon always evaluated integer division and modulo using Scala if the divisor and dividend were integer literals (and the divisor is non-zero). If the divisor or the dividend are not integer literals, then Carbon uses Boogie's division, which uses the SMT division. Scala's division differs from the SMT division and so this leads to inconsistencies.
This pull request simplifies integer division and modulo only if the divisor and dividend are nonnegative (and the divisor is nonzero), which removes this inconsistency.
This issue was already reported in viperproject/silver#297.