Fixes filtering of termination-related failures#584
Merged
Conversation
mschwerhoff
approved these changes
Dec 16, 2021
mschwerhoff
left a comment
mschwerhoff
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, modulo the two minor comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assert stmts generated by the termination plugin have no position and no information.
Thus, the current filtering of failures introduces by PR #575 will filter these failures (see example added by Silver PR #546).
This fix adapts the filtering mechanism to take error transformers into account.
@mschwerhoff: What is the convention with error transformers? Should they be applied as early as possible? I was not sure whether the failures should contain the untransformed errors (as it is now) or whether it would be fine to only return the transformed errors.