Skip to content

Field and predicate specific FVFs#649

Merged
marcoeilers merged 4 commits into
masterfrom
meilers_field_specific_fvfs
Jan 17, 2023
Merged

Field and predicate specific FVFs#649
marcoeilers merged 4 commits into
masterfrom
meilers_field_specific_fvfs

Conversation

@marcoeilers

Copy link
Copy Markdown
Contributor

Making FVF sorts (and the predicate equivalent) field-specific. The point is to avoid triggering the FVF extensionality axioms on pairs of FVFs of different fields (or predicates), which is never useful, and looks potentially expensive.

Draft, still testing performance implications.

@jcp19

jcp19 commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

@marcoeilers does this lead to any noticeable speed-up in our benchmarks?

PS: I can also test it on SCION if you need more benchmarking data

@marcoeilers marcoeilers closed this Nov 2, 2022
@jcp19 jcp19 reopened this Nov 12, 2022
@jcp19

jcp19 commented Jan 12, 2023

Copy link
Copy Markdown
Contributor

Did a few extra tests with SCION packages. In one instance (package slayers/path/onehop) this lead to a drop in half of the verification time (from 6min16s to 3min36s). For the router package, verification went from ~30min to ~26min

Comment thread src/main/resources/field_value_functions_axioms.smt2
Comment thread src/main/scala/supporters/qps/PredicateAndWandSnapFunctionsContributor.scala Outdated
@jcp19 jcp19 marked this pull request as ready for review January 12, 2023 14:13
@marcoeilers marcoeilers merged commit 815835e into master Jan 17, 2023
@marcoeilers marcoeilers deleted the meilers_field_specific_fvfs branch January 17, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants