Updating --conditionalizePermissions#685
Merged
Merged
Conversation
…ding the transformation if it can cause well-definedness issues or involves wildcards
jcp19
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silicon's experimental
--conditionalizePermissionsflag performs a program transformation that rewrites access predicates under conditions, i.e.,b ==> acc(e.f, r), into unconditional access predicates with conditional permission amounts, i.e.,acc(e.f, b ? r : none), with the intention of preventing Silicon from branching on the value ofbto reduce the number of branches.This PR updates the rewriter to add features and fix some issues to make it more generally usable:
b ==> P --* Q.ris a wildcard (since that leads to completeness issues), or wheneis a complex expression that is not always well-defined, since the well-definedness ofemay depend on conditionb: Givenacc(e.f, b ? r : none), Silicon checks that e is well-defined in the current context in general, not only ifbis true.b ? P : Qinto a conjunction of implicationsb ==> P && !b ==> Q, which is then transformed as described above (ternary expressions were previously left untransformed).Finally, it fixes an issue that occurs when packaging a wand that contains a quantified permission with a complex permission amount (which is technically a different issue, but will happen more often when using the transformation).