Fix issue #688#690
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #688. The problem in that issue is that when consuming a QP with an unsatisfiable condition, trigger evaluation results in more unsatisfiable assumptions. This is no problem if these assumptions are assumed conditionally under the quantifier condition, but they were not:
Since they were part of a path condition layer that did not contain the branch condition (this layer is introduced specifically before trigger evaluation to be able to identify the newly-added assumptions), they were assumed unconditionally, which is unsound.
This PR removed the new layer and all its assumptions after trigger evaluation. They are then assumed again only if the trigger could be evaluated successfully, but crucially, on the layer that contains the branch condition, so they will be assumed conditionally.