Disabling non-linear integer arithmetics#783
Merged
Merged
Conversation
jcp19
reviewed
Dec 1, 2023
jcp19
left a comment
jcp19
left a comment
Contributor
There was a problem hiding this comment.
I have a few minor comments that we should address before merging. Could we also add a test that typically passes, but which should fail with the new flag to make sure that the implementation has the expected behaviour?
Co-authored-by: João Pereira <joaopereira.19@gmail.com>
Co-authored-by: João Pereira <joaopereira.19@gmail.com>
Co-authored-by: João Pereira <joaopereira.19@gmail.com>
jcp19
reviewed
Dec 2, 2023
jcp19
approved these changes
Dec 2, 2023
jcp19
left a comment
jcp19
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I added a comment to address if possible though
Contributor
|
We already have a flag to pass options to Z3, right? Is this just tomake it more convenient? |
Contributor
Author
|
Yes, it seems useful to have it as a separate option since we use it more and more (especially in scion) |
Contributor
|
Okay, makes sense. Would be nice if you could make it work for Z3 API as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a flag in silicon to disable non-linear integer arithmetics when Z3 via STDIO is used.