Better heuristics for QPs#789
Merged
Merged
Conversation
…ied variables being declared, and to avoid relying on any knowledge about them
Contributor
Contributor
Author
|
Haha :D |
jcp19
approved these changes
Dec 20, 2023
jcp19
left a comment
Contributor
There was a problem hiding this comment.
I'm not an expert in this code, but the changes look ok to me. Unfortunately, SCION did not get faster with this :'(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Silicon's heuristics for selecting in what order to use QP chunks when exhaling QPs are somewhat lacking (see issue #788).
This PR adds a much more precise kind of heuristics that should help a lot with performance when QPs of the same "shape" (as in, the same number and types of quantified variables) are inhaled and exhaled repeatedly.
E.g., if the QP we're looking to find or remove has a quantified variable
i: Intand receiver termf(a, i), and an existing chunk with quantified variablex: Inthas receiver termf(g(), x), wherea == g(), then that chunk would be selected first. We use the decider to check for equality, so it can take all knowledge Silicon currently has into account.If no such chunk exists, the standard hint based heuristics are used.