symbexlog: fix conditionExp for big and/or#790
Merged
Conversation
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Noticed that sometimes the wrong branch condition is reported in the symbolic execution log. The branching record can contain both the expression (silver) and the term (smt-ish) for the branch, we prefer to render the expression when possible.
What I did:
MemberSymbExLogger.insertBranchPoint; there's just two:Executor, but this doesn't report any condition expressions anyway;brancher.branch, where theconditionExpis passed in to the method.At every usage of
brancher.branchI checked that theconditionExpthat is passed is exactly the expression evaluated for the term that is passed. That is: this was the only place it did not match.