Fixing issue #842#843
Merged
Merged
Conversation
…fiable condition in evalQuantified
This was referenced May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When producing or consuming a QP,
evalQuantifiedfirst evaluates and assumes the QP's condition. This condition could of course be unsatisfiable, in which case producing or consuming the QP should not affect the state and verification should continue.Currently, however, the following is possible:
evalQuantifiedlocally assumes false (as it should)evalQuantifieditself is invoked only from said continuation, verification just stops at this point, and any subsequent conjuncts are never produced/consumed and any subsequent statements never executed. This is obviously unsound (see issue Unsoundness related to QPs with unsatisfiable conditions #842 for an example), since only the path in the quantifier where its condition is true was unreachable, not the entire path the quantifier is on.This PR changes
evalQuantifieds.t. its continuation is always called, now with an optional result to tell the caller if the above scenario happened and the quantifier is therefore trivially satisfied.