Not pushing conditions using permission introspection further in#853
Merged
marcoeilers merged 4 commits intoJun 17, 2024
Merged
Conversation
jcp19
approved these changes
Jun 17, 2024
jcp19
left a comment
Contributor
There was a problem hiding this comment.
The code looks ok to me, I have a few questions about the tests though
jcp19
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--conditionalizePermissionscommand line option rewrites implications and ternary expressions to avoid branching.The general pattern is that
e1 ==> acc(e2.f, e3)is rewritten toacc(e2.f, e1 ? e3 : none.This rewriting is not always sound if the condition (
e1in this case) uses permission introspection.Example:
must not be rewritten to
since the value of
perm(P1(x)) >= writechanges.This PR conservatively prevents any rewriting where the condition contains
permorforperm.This fixes one issue mentioned in #851.