Fix macro transfer between verifiers in parallel branch verification#872
Merged
Conversation
marcoeilers
commented
Sep 16, 2024
marcoeilers
commented
Contributor
- Simplifies the way we move function and macro declarations between prover instances when verifying different branches on different solvers in parallel
- Gets rid of the stack of declared functions and macros in the Decider
- Should improve performance of the relevant code for large examples (we used to do a lot of checks if a vector contains a value, now we check this on a HashSet)
- Hopefully fixes some issues the more complex previous solution had in the process
… that seems to actually work. Also maintaining set of declared macro names for faster lookup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.