Fixing issues #410 and #338#899
Merged
Merged
Conversation
ArquintL
approved these changes
Feb 12, 2025
ArquintL
left a comment
Member
There was a problem hiding this comment.
Looks good to me; although, I must admit that I don't fully grasp the necessity of optimalSnapshotSort
Contributor
Author
Depending on what is in a predicate, its snapshot has a different sort (e.g. a predicate containing only a permission to an int field will have type int; if it contains multiple values, it'll be type snap). The fix needs us to continue verification when we're in an infeasible state when reading a resource we don't have any chunk of; to do that, we need to return a fresh value of the expected sort. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inside a package statement, we have to always call the continuation, we cannot use shortcuts that just return
Success(). If we do that, Silicon still continues verification after the package block, but it will not know that it has to continue with the heap from the infeasible branch.Thus, this PR:
exhaleExtdoes not work for this because it's temporarily set to false e.g. when evaluating pure assertions)Success()when in an infeasible branch s.t. verification continues, possibly with an unknown value if we're reading a field that we don't have permission to