Fixing issue #903#904
Merged
Merged
Conversation
ArquintL
approved these changes
Mar 4, 2025
Contributor
|
@marcoeilers I noticed that this PR changed the |
Member
|
Great catch! Yes, we'll have to adapt that one as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The underlying issue was that fresh values introduced by state consolidation during function verification were made global variables that were then constrained by every function invocation, and different invocations could lead to a contradiction.
Instead, these global variables should be functions that depend on the function arguments, and we should constrain their values for the current function arguments (similar to another recent issue #895).
Closes #903