Stricter triggers on FVF snap extensionality axiom #936
Merged
Conversation
…d expensive instantiations
Contributor
Author
|
This helps a bit with the example you sent me earlier @jcp19, though it's still slower than it should be. |
jcp19
approved these changes
Jul 13, 2025
jcp19
left a comment
jcp19
left a comment
Contributor
There was a problem hiding this comment.
I'm not an expert in this part of the code, but from what I see, it looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FVFs map receivers to field values. Some FVFs also have a defined domain, so they're associated with a set of receivers for which they have a value. This PR adds a new term,
HasDomain, that marks FVFs that have this set.The point is that the FVF extensionality axiom which is needed for function framing, is quadratic in nature, and can be quite expensive, only makes sense to trigger for FVFs that have a defined domain, because two FVFs are equal only if they have the same values and domain, which requires the domain to be defined.
So by marking FVFs with domains using the new term, we can add HasDomain as an additional trigger for the extensionality axiom for FVFs to avoid triggering it on FVFs that don't have domains, for which it is never useful.