Pass return types to DomainFuncApp as for FuncApp#490
Merged
Conversation
fpoli
approved these changes
Jan 5, 2021
fpoli
left a comment
fpoli
left a comment
Member
There was a problem hiding this comment.
It looks good to me. To fix that test that is failing on master it should be enough to use a more recent Java version, like this commit does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor of DomainFuncApp currently requires that the function's return type is passed using call-by-name. If there is no good reason for this, it would be convenient for some frontends, e.g., Prusti, to pass the return type as for standard function applications.
Since the signature of domain function applications is changed - it now matches those of function applications - merging this PR may break some frontends.
The PR passes the test suites of carbon, silicon, and silver (except one test already failing in master).