Faster NameAnalyser implementation#631
Merged
Merged
Conversation
fpoli
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current NameAnalyser's check to ensure that local variables are not used before they are declared is really really slow for large methods (see issue #630).
It first walks through the entire PAST and collects all declarations, then, in a second pass, it iterates over the the entire PAST again and, for every local variable reference it finds, walks through all AST nodes occurring in the current method again and checks if the current variable reference is found before its declaration (method
containsSubnodeBefore).This PR simplifies the process as follows:
This has the drawback that our error message can no longer state whether we are referencing a local variable that has not been declared yet or one that has not been declared at all, but it massively speeds up the entire checking process for large methods.
Also, I added an
isPurefunction on the AST node for Viper functions because I need this for something else.