Avoid linear lookups in a Program#659
Merged
Merged
Conversation
fpoli
force-pushed
the
optimize-lookups
branch
5 times, most recently
from
bee909f to
bd76ebb
Compare
fpoli
changed the title
marcoeilers
approved these changes
Mar 10, 2023
marcoeilers
left a comment
marcoeilers
left a comment
Contributor
There was a problem hiding this comment.
LGTM (assuming toMap actually gives you a HashMap and not a ListMap that doesn't perform any better than the current linear traversal)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces several lazy maps that index the program items by name.
Fixes #657.