Avoiding folds in the encoding of unfolding expressions#773
Merged
Conversation
Contributor
|
I'm surprised that we are still running into non-linear terms here, considering that I am using the silicon branch with the wildcard multiplication optimization |
…b.com/viperproject/silver into meilers_termination_simpler_unfolding
Contributor
Author
|
That's probably because I'm an idiot and forgot some cases there (added them now) |
Contributor
|
I would be happy to merge this as soon as the release is out (assuming the tests are passing) |
jcp19
approved these changes
Feb 19, 2024
ArquintL
pushed a commit
that referenced
this pull request
Feb 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids having to prove that the predicate can be folded, which is not needed (but can still sometimes fail e.g. if wildcard multiplications lead to non-linear terms, like in an example that @jcp19 found).