Fixing issue #849 #857
Merged
Merged
Conversation
Contributor
Author
|
@ArquintL I'd like to use his in the SIF plugin to make sure SIF expressions in triggers don't lead to crashes, as is currently the case. |
ArquintL
approved these changes
Apr 4, 2025
ArquintL
left a comment
ArquintL
left a comment
Member
There was a problem hiding this comment.
LGTM but I've left one minor remark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExtensionExpgets new abstract methodsextensionIsValidTriggerandextensionIsForbiddenInTrigger(similar toextensionIsPureetc.), which returnfalseandtrueby default, which can be used by extension expressions to decide whether they can be used as triggers or not. This replaces the previous behavior where our consistency checks would always reject extension expressions as triggers.This fixes issue #849.