Removed { as trigger#333
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes the "{" character as a completion trigger and adds a new SignatureHelp utility file for LSP functionality.
Changes:
- Removed "{" from the list of completion trigger characters in
Receiver.scala - Added new
SignatureHelp.scalafile defining LSP signature help types
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/scala/viper/server/frontends/lsp/ast/utility/SignatureHelp.scala | Introduces new trait and case classes for signature help functionality, providing structured types for displaying function/method signatures |
| src/main/scala/viper/server/frontends/lsp/Receiver.scala | Removes "{" from completion trigger characters, now only triggering on ".", ":", "(", and "[" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.