Skip to content

fix(create-vite): distinguish pnpm pkgManager#4220

Merged
patak-cat merged 9 commits intovitejs:mainfrom
heydong1:main
Jul 30, 2021
Merged

fix(create-vite): distinguish pnpm pkgManager#4220
patak-cat merged 9 commits intovitejs:mainfrom
heydong1:main

Conversation

@heydong1
Copy link
Copy Markdown
Contributor

@heydong1 heydong1 commented Jul 12, 2021 •
edited
Loading

Description

Same as #4193 , slove conflict.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@heydong1
Copy link
Copy Markdown
Contributor Author

heydong1 commented Jul 12, 2021

@antfu @Shinigami92 review

antfu
antfu previously approved these changes Jul 12, 2021
View reviewed changes
@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jul 12, 2021
Shinigami92
Shinigami92 previously approved these changes Jul 12, 2021
View reviewed changes
patak-cat
patak-cat requested changes Jul 14, 2021
View reviewed changes
Comment thread packages/create-vite/index.js Outdated
@heydong1 heydong1 dismissed stale reviews from Shinigami92 and antfu via 1a1a95a July 14, 2021 14:20
@heydong1 heydong1 requested a review from patak-cat July 14, 2021 14:22
@heydong1
Copy link
Copy Markdown
Contributor Author

heydong1 commented Jul 30, 2021

@patak-js Maybe you forgot it?

@patak-cat
Copy link
Copy Markdown
Member

patak-cat commented Jul 30, 2021

Tests are blocked, I dont know why. Would you try to merge main?

Shinigami92
Shinigami92 reviewed Jul 30, 2021
View reviewed changes
Comment thread packages/create-vite/index.js
Comment thread packages/create-vite/index.js Outdated
@heydong1 @Shinigami92
fix(create-vite): distinguish pkgManager
40823e0 
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Shinigami92
Shinigami92 previously approved these changes Jul 30, 2021
View reviewed changes
@heydong1
Copy link
Copy Markdown
Contributor Author

heydong1 commented Jul 30, 2021

Tests are blocked, I dont know why. Would you try to merge main?

This may be because I send a request review to you, and util mentioned that 'patak-js requested changes', I have marked that conversation as resolved, sorry for I don't have much experience in this field.

patak-cat
patak-cat previously approved these changes Jul 30, 2021
View reviewed changes
@patak-cat
Copy link
Copy Markdown
Member

patak-cat commented Jul 30, 2021

Tests are blocked, I dont know why. Would you try to merge main?

This may be because I send a request review to you, and util mentioned that 'patak-js requested changes', I have marked that conversation as resolved

I don't think that is the case, it looks like a GitHub bug to me

sorry for I don't have much experience in this field.

Thanks for this PR, this is a great addition and I hope we'll see you around with other improvements later

patak-cat
patak-cat reviewed Jul 30, 2021
View reviewed changes
Comment thread packages/create-vite/index.js Outdated
@patak-cat patak-cat dismissed stale reviews from Shinigami92 and themself via 78deec2 July 30, 2021 12:41
@heydong1 heydong1 closed this Jul 30, 2021
@heydong1 heydong1 reopened this Jul 30, 2021
@patak-cat patak-cat merged commit c0a3dbf into vitejs:main Jul 30, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@heydong1 @aleclarson
fix(create-vite): distinguish pnpm pkgManager (vitejs#4220)
ec7fc3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat left review comments

@antfu antfu antfu left review comments

+1 more reviewer

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@heydong1 @patak-cat @Shinigami92 @antfu
⚡