Skip to content

fix(create-vite): distinguish pnpm pkgManager #4220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-cat merged 9 commits into from
Jul 30, 2021
Merged

fix(create-vite): distinguish pnpm pkgManager #4220

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
738386e
fix(create-vite): distinguish pnpm pkgManager
heydong1 Jul 12, 2021
3e94883
Merge branch 'main' into main
antfu Jul 12, 2021
fea1bfd
fix(create-vite): distinguish pkgManager
heydong1 Jul 14, 2021
1a1a95a
Merge branch 'main' of https://github.com/cabbage9/vite
heydong1 Jul 14, 2021
2d13600
Merge branch 'vitejs:main' into main
heydong1 Jul 14, 2021
67ffa26
Merge branch 'main' into main
Shinigami92 Jul 30, 2021
40823e0
fix(create-vite): distinguish pkgManager
heydong1 Jul 30, 2021
9197e12
Merge branch 'main' into main
Shinigami92 Jul 30, 2021
78deec2
chore: missing spacing
patak-cat Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions packages/create-vite/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,14 +254,17 @@ async function init() {

write('package.json', JSON.stringify(pkg, null, 2))

const pkgManager = /yarn/.test(process.env.npm_execpath) ? 'yarn' : 'npm'
const pkgManager =
pmFromUserAgent(process.env.npm_config_user_agent)?.name || 'npm'
Comment thread
heydong1 marked this conversation as resolved.
Outdated

console.log(`\nDone. Now run:\n`)
if (root !== cwd) {
console.log(` cd ${path.relative(cwd, root)}`)
}
console.log(` ${pkgManager === 'yarn' ? `yarn` : `npm install`}`)
console.log(` ${pkgManager === 'yarn' ? `yarn dev` : `npm run dev`}`)
console.log(` ${pkgManager === 'yarn' ? `yarn` : `${pkgManager} install`}`)
console.log(
` ${pkgManager === 'yarn' ? `yarn dev` : `${pkgManager} run dev`}`
)
Comment thread
heydong1 marked this conversation as resolved.
Outdated
console.log()
}

Expand Down Expand Up @@ -318,6 +321,20 @@ function emptyDir(dir) {
}
}

/**
* @param {string | undefined} userAgent process.env.npm_config_user_agent
* @returns object | undefined
*/
function pmFromUserAgent(userAgent) {
if (!userAgent) return undefined
const pmSpec = userAgent.split(' ')[0]
const pmSpecArr = pmSpec.split('/')
return {
name: pmSpecArr[0],
version: pmSpecArr[1]
}
}

init().catch((e) => {
console.error(e)
})
⚡