Skip to content

fix(create-vite): allow slash at the end of project path#6897

Merged
patak-cat merged 4 commits intovitejs:mainfrom
Olyno:fix/create-vite-path
May 9, 2022
Merged

fix(create-vite): allow slash at the end of project path#6897
patak-cat merged 4 commits intovitejs:mainfrom
Olyno:fix/create-vite-path

Conversation

@Olyno
Copy link
Copy Markdown
Contributor

@Olyno Olyno commented Feb 13, 2022

Description

This pull request fix the root path when creating a new project. It looks like the current way doesn't get the relative ./ path.

Additional context

fix: #6896


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Comment thread packages/create-vite/index.js Outdated
@Niputi Niputi changed the title fix: path of project root (fix #6896) fix: path of project root Feb 13, 2022
@patak-cat patak-cat changed the title fix: path of project root fix(create-vite): allow slash at the end of project path May 9, 2022
@patak-cat patak-cat merged commit 8167db3 into vitejs:main May 9, 2022
@Olyno Olyno deleted the fix/create-vite-path branch May 9, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create-vite issue of prompts after scaffolding project

3 participants