Skip to content

fix(create-vite): allow slash at the end of project path #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patak-cat merged 4 commits into from
May 9, 2022
+5 −2
Merged

fix(create-vite): allow slash at the end of project path #6897

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
938df2b
fix: path of project root (fix #6896)
Olyno Feb 13, 2022
29e2ff7
fix: root path security concern
Olyno Feb 13, 2022
1887315
revert: feat: use path.resolve instead of path.join
Olyno Feb 14, 2022
f33951f
fix: undefined property call
Olyno Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/create-vite/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ async function init() {
// user choice associated with prompts
const { framework, overwrite, packageName, variant } = result

const root = path.join(cwd, targetDir)
const root = path.resolve(cwd, targetDir)
Comment thread
bluwy marked this conversation as resolved.
Outdated

if (overwrite) {
emptyDir(root)
Expand Down
⚡