Skip to content

docs: update git hooks validate package in CONTRIBUTING.md#10454

Merged
patak-cat merged 1 commit intovitejs:mainfrom
wangkaiwd:doc-typo
Oct 14, 2022
Merged

docs: update git hooks validate package in CONTRIBUTING.md#10454
patak-cat merged 1 commit intovitejs:mainfrom
wangkaiwd:doc-typo

Conversation

@wangkaiwd
Copy link
Copy Markdown
Contributor

@wangkaiwd wangkaiwd commented Oct 13, 2022

Description

Update git hooks validate package in CONTRIBUTING.md

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92
Copy link
Copy Markdown
Member

That's not what "fixing a typo" is 🤔
Could you please find another name for the PR title? As the PR title will become the commit message if merged.

@patak-cat patak-cat changed the title docs: fix typo in CONTRIBUTING.md docs: fix git hooks link in CONTRIBUTING.md Oct 14, 2022
@patak-cat patak-cat added the p1-chore Doesn't change code behavior (priority) label Oct 14, 2022
@patak-cat patak-cat merged commit e793df3 into vitejs:main Oct 14, 2022
@wangkaiwd wangkaiwd changed the title docs: fix git hooks link in CONTRIBUTING.md docs: update git hooks validate package in CONTRIBUTING.md Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants