fix(importGlob): don't warn when CSS default import is not used#11121
Merged
patak-cat merged 6 commits intovitejs:mainfrom Nov 30, 2022
Merged
Conversation
bluwy
reviewed
Nov 30, 2022
Member
bluwy
left a comment
There was a problem hiding this comment.
Neat trick. Only one comment for cleanup but this is much nicer DX-wise.
bluwy
approved these changes
Nov 30, 2022
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
Closed
7 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I implemented #11103 (comment) by moving the warning to runtime.
Since we only output the warning only on dev, I think we could move it.
This PR will change a property to getter. Though, I think this change won't break things most of the time.
refs #11094 #11103
Additional context
Note that sourcemap is currently broken. See #11122.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).