feat(imports): support import attributes - fixes #14674#15654
Closed
matthewp wants to merge 3 commits intovitejs:mainfrom
Closed
feat(imports): support import attributes - fixes #14674#15654matthewp wants to merge 3 commits intovitejs:mainfrom
matthewp wants to merge 3 commits intovitejs:mainfrom
Conversation
|
|
7 tasks
bluwy
reviewed
Jan 19, 2024
Contributor
Author
|
I'm not sure why this is failing in CI, likely a race condition some how. I'll take a look. |
Contributor
Author
|
I'm not working on this at the moment, so closing. |
coxmi
added a commit
to coxmi/ssr-tools
that referenced
this pull request
Feb 12, 2024
Waiting on vitejs/vite#12140 or vitejs/vite#15654 to allow import assertions
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14674
Adds support for import attributes by parsing them in the import analysis plugin.
Additional context
How this works:
{ foo: 'bar' }What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).