fix(css): resolve relative imports in sass properly on Windows#19920
Merged
sapphi-red merged 1 commit intovitejs:mainfrom Apr 24, 2025
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fileURLToPath('file:///C:/foo.js', { windows: false })returns/C:/foo.js. Even with this output, it still worked because the internal resolve plugin supports that format (/C:/foo.js) as well.vite/packages/vite/src/node/plugins/resolve.ts
Lines 262 to 274 in 16a73c0
But the expected result here for this input is
C:/foo.js, and this PR fixes the condition to usewindowsoption.