feat: Closer parity to Preact template on Preact Typescript template.#1996
Merged
yyx990803 merged 1 commit intovitejs:mainfrom Feb 12, 2021
kerimhudson:closer-parity-to-preact-template
Merged
feat: Closer parity to Preact template on Preact Typescript template.#1996yyx990803 merged 1 commit intovitejs:mainfrom kerimhudson:closer-parity-to-preact-template
yyx990803 merged 1 commit intovitejs:mainfrom
kerimhudson:closer-parity-to-preact-template
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having played with both the Preact and Preact TypeScript templates on Vite, I find that the vanilla Preact one offers a stronger starting point than the TypeScript one as it allows you to
import { h, Fragment } from 'preact'automatically, and not have to add it to every file.This could also be added to the TypeScript version to allow for a faster and nicer development experience. This PR attempts to implement that feature by using the same methods as the vanilla Preact template. It requires creating a
preact.d.tsin thesrcdirectory to ensure code checking works in VS Code.The change is fairly small so thought it better to make a PR than a discussion first as it'll be easier to just see the code.
(I tried to ensure following the contribution guidelines, but apologies if I missed anything).