Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions packages/vite/src/node/__tests__/plugins/empty-css.spec.ts
Comment thread
sapphi-red marked this conversation as resolved.
Outdated
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
import { join } from 'node:path'
import { mkdirSync, readFileSync, rmSync, writeFileSync } from 'node:fs'
import { describe, expect, test } from 'vitest'

const testDir = join(__dirname, '../__test-temp-empty-css')

describe('empty CSS entry fix', () => {
test('empty CSS entries should generate CSS files, not JS files', async () => {
// Setup test directory
try {
rmSync(testDir, { recursive: true, force: true })
} catch {}
mkdirSync(testDir, { recursive: true })

// Create test files
writeFileSync(join(testDir, 'empty.css'), '/* comment only */')
writeFileSync(join(testDir, 'completely-empty.css'), '')
writeFileSync(join(testDir, 'valid.css'), '.test { color: red; }')

// Create package.json
writeFileSync(
join(testDir, 'package.json'),
JSON.stringify({
name: 'test-empty-css',
type: 'module',
}),
)

// Build with Vite
const { build } = await import('vite')
await build({
configFile: false,
root: testDir,
logLevel: 'error',
build: {
manifest: true,
rollupOptions: {
input: [
join(testDir, 'empty.css'),
join(testDir, 'completely-empty.css'),
join(testDir, 'valid.css'),
],
},
},
})

// Check manifest
const manifestPath = join(testDir, 'dist/.vite/manifest.json')
const manifest = JSON.parse(readFileSync(manifestPath, 'utf-8'))

// All CSS entries should generate CSS files, not JS files
for (const [key, entry] of Object.entries(manifest)) {
if (key.endsWith('.css')) {
expect(
(entry as any).file,
`${key} should generate .css file, not .js`,
).toMatch(/\.css$/)
expect(
(entry as any).file,
`${key} should not generate .js file`,
).not.toMatch(/\.js$/)
}
}

// Cleanup
try {
rmSync(testDir, { recursive: true, force: true })
} catch {}
})
})
2 changes: 1 addition & 1 deletion packages/vite/src/node/plugins/css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -824,7 +824,7 @@ export function cssPostPlugin(config: ResolvedConfig): Plugin {
}
}

if (chunkCSS) {
if (chunkCSS || (isPureCssChunk && chunk.isEntry)) {
Comment thread
sapphi-red marked this conversation as resolved.
Outdated
if (isPureCssChunk && (opts.format === 'es' || opts.format === 'cjs')) {
// this is a shared CSS-only chunk that is empty.
pureCssChunks.add(chunk)
Expand Down
1 change: 1 addition & 0 deletions playground/css/empty.css
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/* This is an empty CSS file for testing empty CSS entries */
Empty file added playground/css/empty2.css
Empty file.
15 changes: 15 additions & 0 deletions playground/css/vite.config-empty-css.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import path from 'node:path'
import { defineConfig } from 'vite'

export default defineConfig({
build: {
manifest: true,
cssCodeSplit: true, // Ensure CSS code splitting
rollupOptions: {
input: [
'empty.css', // Empty CSS file with comments
'empty2.css', // Completely empty CSS file
],
},
},
})
Loading