Skip to content

feat(optimizer): improve dependency optimization error messages with esbuild formatMessages #20525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sapphi-red merged 4 commits into from
Aug 5, 2025
+14 −2
Merged

feat(optimizer): improve dependency optimization error messages with esbuild formatMessages #20525

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3c3b6e1
Initial plan
Copilot Jul 31, 2025
42d8e4c
Improve dependency optimization error messages with context
Copilot Jul 31, 2025
d8f2453
Use esbuild formatMessages pattern for dependency optimization errors
Copilot Aug 1, 2025
4d6a070
refactor: simplify error message string without template literal
Copilot Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions packages/vite/src/node/optimizer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { promisify } from 'node:util'
import { performance } from 'node:perf_hooks'
import colors from 'picocolors'
import type { BuildContext, BuildOptions as EsbuildBuildOptions } from 'esbuild'
import esbuild, { build } from 'esbuild'
import esbuild, { build, formatMessages } from 'esbuild'
import { init, parse } from 'es-module-lexer'
import { isDynamicPattern } from 'tinyglobby'
import type { ResolvedConfig } from '../config'
Expand Down Expand Up @@ -724,12 +724,24 @@ export function runOptimizeDeps(
return successfulResult
})

.catch((e) => {
.catch(async (e) => {
if (e.errors && e.message.includes('The build was canceled')) {
// esbuild logs an error when cancelling, but this is expected so
// return an empty result instead
return cancelledResult
}
const prependMessage = colors.red(
'Error during dependency optimization:\n\n',
)
if (e.errors) {
const msgs = await formatMessages(e.errors, {
kind: 'error',
color: true,
})
e.message = prependMessage + msgs.join('\n')
} else {
e.message = prependMessage + e.message
}
throw e
})
.finally(() => {
Expand Down
Loading
⚡