fix(bundled-dev): reject requests to HMR patch files in non potentially trustworthy origins#22269
Merged
sapphi-red merged 2 commits intovitejs:mainfrom Apr 20, 2026
Conversation
…ly trustworthy origins
sapphi-red
added
p2-edge-case
sapphi-red
deleted the
fix/reject-requests-to-hmr-patch-files-from-non-potentially-trust-worthy-origins
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid HMR patch files (that is used for full bundle mode) to be fetched from untrusted origins (like the other requests), there was a middleware to block those requests by checking
Sec-Fetch-*headers. This did not work for non-potentially trustworthy origins because browsers doesn't send the headers for them.This PR replaces that by ensuring an ESM syntax to exist in HMR patch files.
close #21849 (indirectly)