Skip to content

chore: ignore unknown file type in prettier#4738

Merged
patak-cat merged 1 commit intovitejs:mainfrom
hannoeru:chore/prettier-ignore-unknown
Aug 26, 2021
Merged

chore: ignore unknown file type in prettier#4738
patak-cat merged 1 commit intovitejs:mainfrom
hannoeru:chore/prettier-ignore-unknown

Conversation

@hannoeru
Copy link
Copy Markdown
Contributor

@hannoeru hannoeru commented Aug 25, 2021

Description

Allow commit files like example.png

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Aug 26, 2021
Shinigami92
Shinigami92 approved these changes Aug 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, didn't know this

@patak-cat patak-cat merged commit 4eafd7e into vitejs:main Aug 26, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@hannoeru @aleclarson
chore: ignore unknown file type in prettier (vitejs#4738)
faa3d01
@jay-Anonymous jay-Anonymous mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

+1 more reviewer

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hannoeru @patak-cat @Shinigami92
⚡