Added a new "me" command to download by liked albums/tracks#185
Open
iamABH wants to merge 4 commits intovitiko98:masterfrom
Open
Added a new "me" command to download by liked albums/tracks#185iamABH wants to merge 4 commits intovitiko98:masterfrom
iamABH wants to merge 4 commits intovitiko98:masterfrom
Conversation
Owner
|
Hey, thanks for this PR! And sorry for the late reply... Sadly, I can't test it right now (I don't have any Qobuz account). I'd just merge it if it was a small change, but this PR would make substantial changes to I'll try to get a subscription as soon as possible. |
Author
|
No problem, keep me informed :) |
|
Would really appreciate this merge; would make the script a lot more useful for me. |
melindafunk
suggested changes
Mar 17, 2023
qobuz_dl/core.py
Outdated
| embed_art=False, | ||
| lucky_limit=1, | ||
| lucky_type="album", | ||
| me_type="album", |
Author
There was a problem hiding this comment.
Fixed ! Thanks for reviewing this :)
qobuz_dl/commands.py
Outdated
| "-t", | ||
| "--type", | ||
| default="album", | ||
| help=("type of items to search (albums, tracks) (default: album)"), |
Author
There was a problem hiding this comment.
It's already fixed in newest commits
Author
|
Any plan to merge this ? @vitiko98 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello !
I just added a new "me" command to download by liked albums/tracks.
I also manage the offset / limit pagination in Qobuz API on this command.
The endpoint "favorite/getUserFavorites" was already implemented in the Qobuz Client and I tweaked it a little bit to implement tracks type too.
Let me know if there is any issues.