use metadata version tag to determine full track title#308
Open
Zazcallabah wants to merge 1 commit intovitiko98:masterfrom
Open
use metadata version tag to determine full track title#308Zazcallabah wants to merge 1 commit intovitiko98:masterfrom
Zazcallabah wants to merge 1 commit intovitiko98:masterfrom
Conversation
Very neccessary in order to distinguish remixes from each other, otherwise the tool will avoid downloading any but the first remixes of the same base track. We cant really do this by simple templating since we probably dont want a trailing " ()" on every track title. If there is conditionals available in the templating that would probably be much better though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very neccessary in order to distinguish remixes from each other, otherwise the tool will avoid downloading any but the first remixes of the same base track.
We cant really do this by simple templating since we probably dont want a trailing " ()" on every track title. If there is conditionals available in the templating that would probably be much better though. in that case we just insert the conditional in "DEFAULT_TRACK" but as far as i can tell the default python formatter does not support conditionals in the format string.