checker: fix missing re-check of recursive generic function #17592
Merged
spytheman merged 1 commit intovlang:masterfrom Mar 11, 2023
Merged
checker: fix missing re-check of recursive generic function #17592spytheman merged 1 commit intovlang:masterfrom
spytheman merged 1 commit intovlang:masterfrom
Conversation
felipensp
changed the title
spytheman
reviewed
Mar 11, 2023
| a T | ||
| } | ||
|
|
||
| fn test_main() { |
Contributor
There was a problem hiding this comment.
Please name the test functions with more specific names - from just test_main, it is not clear what does this test. The name of the test file is also not very helpful.
In several months, it would be hard for someone to understand why was this added (if suddenly it starts failing), by just looking at local information, without looking back to the PR/commit itself.
l1mey112
pushed a commit
to l1mey112/v
that referenced
this pull request
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16962