parser: fix comments parsing on map init#18389
Merged
medvednikov merged 1 commit intovlang:masterfrom Jun 9, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #18362
🤖 Generated by Copilot at afb82d0
This pull request fixes a bug in the parser and the formatter that caused comments inside map initialization expressions to be deleted. It also adds a test case in
vlib/v/fmt/tests/map_init_comments_keep.vvto verify the correct behavior.🤖 Generated by Copilot at afb82d0
p.inside_map_initflag before eating comments inp.expr()(link)vlib/v/fmt/tests/map_init_comments_keep.vvto show that comments after the colon are kept, but comments after the comma are deleted (link)