Skip to content

json: change json tests to tests folder#22731

Merged
spytheman merged 6 commits intovlang:masterfrom
enghitalo:json/test-in-test-folder
Nov 12, 2024
Merged

json: change json tests to tests folder#22731
spytheman merged 6 commits intovlang:masterfrom
enghitalo:json/test-in-test-folder

Conversation

@enghitalo
Copy link
Copy Markdown
Contributor

@enghitalo enghitalo commented Nov 1, 2024

@enghitalo enghitalo changed the title json: change json test to json_tests folder json: change json tests to json_tests folder Nov 1, 2024
@enghitalo
Copy link
Copy Markdown
Contributor Author

I have not ideia why this fails hahah

  FAIL  [1605/2074] C:  1827.4 ms, R:     9.050 ms vlib/v/tests/modules/enum_from_string_in_different_mods/src/main_test.v
         retry: 1
      comp_cmd: "D:\a\v\v\v.exe" -skip-running   -o "C:\Users\runneradmin\AppData\Local\Temp\v_0\tsession_18d0_01JBQPJPPNB8BG9M19RSHDYKQ6\1604_0\main_test.exe" "D:\a\v\v\vlib\v\tests\modules\enum_from_string_in_different_mods\src\main_test.v"
       run_cmd: "C:\Users\runneradmin\AppData\Local\Temp\v_0\tsession_18d0_01JBQPJPPNB8BG9M19RSHDYKQ6\1604_0\main_test.exe"
failure code: 1; foutput.len: 364; failure output:
---------------------------------------------------------------------------------------------------- retry: 0 ; max_retry: 0 ; r.exit_code: 1 ; trimmed_output.len: 196
'"C:\Users\runneradmin\AppData\Local\Temp\v_0\tsession_18d0_01JBQPJPPNB8BG9M19RSHDYKQ6\1604_0\main_test.exe"' is not recognized as an internal or external command,

operable program or batch file.

Copy link
Copy Markdown
Contributor

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tests/ is shorter and simpler.
The json_ prefix does not add any additional information since the parent folder is already vlib/json .

@spytheman
Copy link
Copy Markdown
Contributor

I have not ideia why this fails

I've renamed that test as a workaround in 462f186 . It has nothing to do with this PR.

@enghitalo
Copy link
Copy Markdown
Contributor Author

Just tests/ is shorter and simpler.
The json_ prefix does not add any additional information since the parent folder is already vlib/json .

I separated the name to make it easier to merge x.json2, x.json2.decode2 and json. If you prefer, I can divide it into 3 folders like tests/json, tests/encoder, tests/decoder. What do you think?

@spytheman
Copy link
Copy Markdown
Contributor

I think that they should stay as they are in the top level, or use test/ folder.

@enghitalo enghitalo changed the title json: change json tests to json_tests folder json: change json tests to tests folder Nov 12, 2024
@spytheman spytheman merged commit 8ebbace into vlang:master Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants