-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
cgen: fix heap fixed array assign #26169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
spytheman
merged 2 commits into
vlang:master
from
felipensp:fix_fixed_array_heap_assign
Dec 28, 2025
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,18 @@ | ||
| fn test_reference_array_init() { | ||
| mut b := &[5, 6, 7] | ||
| assert '${b}' == '&[5, 6, 7]' | ||
| mut b_fixed := &[5, 6, 7]! | ||
| assert '${b_fixed}' == '&[5, 6, 7]' | ||
| { | ||
| mut a := [1, 2, 3] | ||
| // TODO: this should probably produce a notice at least, | ||
| // (without unsafe{&a}), since it takes the address of something | ||
| // on the stack, that will very soon be out of scope, even | ||
| // though it is still in the same function: | ||
| b = &a | ||
| b_fixed = &[1, 2, 3]! | ||
| } | ||
| println(b) | ||
| assert '${b}' == '&[1, 2, 3]' | ||
| assert '${b_fixed}' == '&[1, 2, 3]' | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does that test, and why is it inside this block, and not outside?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the assignment above it, illustrates that
bcould get the address of something on the stack, and it is inside a {} scope deliberatelythe
b_fixed = &[1, 2, 3]!is just a normal assignment of a heap value in contrastThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that second part should not be here 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
however it does not hurt to have it, it is just confusing and misleading to have it here, instead of before or after the {}