builtin: Simplify linking with libgc#26695
builtin: Simplify linking with libgc#26695programmingkidx wants to merge 3 commits intovlang:masterfrom
Conversation
|
The one test that failed reports this:
cc: C:/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/15.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: C:\Users\RUNNER~1\AppData\Local\Temp\ccQ1OnTq.o:orm_option_array_test.exe.01KK252VBAVG7H7WCZJRD68K79.tmp.c:(.text+0x2da76): undefined reference to `sqlite3_finalize' cc: collect2.exe: error: ld returned 1 exit status I do not believe this is related to my changes. I think this is a bug with orm. |
|
Close/re-open to run CI with latest V. |
Hopefully the issues with the tests have been fixed.
|
Seeing these tests fail:
@JalonSolov Do you think this an issue with my pull request or a problem with the tests? |
|
It's a problem with the tests. Once those are sorted, I'll be re-running CI for a bunch of PRs. |
|
Anything we can do to help? |
|
It's all on Alex, with his v2 changes. |
|
Close/re-open to force CI. |
|
@JalonSolov What would have to be done in order for this pull request to be merged? |
|
Bouncing for another CI check. |
|
Why was "VSL and VTL / vsl-compiles (ubuntu-24.04) (pull_request)" cancelled? The log does not provide a reason. |
|
May have taken too long. Will have to check. |
|
I didn't see any errors in the log but I did see this warning: |
|
Yes, but if you look further, the same test is done on 3 other platforms, and those all succeed in about 5 minutes. The failing test was cancelled after 25 minutes, which means it was cancelled because it was taking too long. That failure has nothing to do with your PR. However, your PR looks as though it will affect all systems, since you removed the entire @medvednikov what do you think of this change? |
cdf4550 to
4dc97d9
Compare
|
@JalonSolov Could you run the CI tests again? |
April 3, 2026 note - 13 tests failed:CI Linux / clang-linux (pull_request)Failing after 24m 😕 |
|
Alex knows. He'll probably get things fixed up soon, and we can try again. |
|
I tried this patch on Debian Linux ARM64 using v 0.5.1 and the result was it worked. I was able to build a program on Linux and it successfully ran. So this means the patch works on both Debian Linux and Mac OS X. Why I think this patch is a good idea
|
Currently V fails to run on Mac OS 10.4 because a feature called rpath is sent to the linker. This feature is only available on Mac OS 10.5 and higher. To fix compatibility with versions of Mac OS X before 10.5, the linking has been simplified to statically link to libgc.a.