cgen: keep interface typeof independent of builtin string#26812
Open
wenxuanjun wants to merge 1 commit intovlang:masterfrom
Open
cgen: keep interface typeof independent of builtin string#26812wenxuanjun wants to merge 1 commit intovlang:masterfrom
wenxuanjun wants to merge 1 commit intovlang:masterfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4fbba2766
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
wenxuanjun
force-pushed
the
fix-interface-typeof-no-builtin
branch
from
f4fbba2 to
4ae5b4c
Compare
wenxuanjun
force-pushed
the
fix-interface-typeof-no-builtin
branch
from
4ae5b4c to
36ee17d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This regressed in #26772, which changed
v_typeof_interface_*helpers fromchar *tostringand introduced an unnecessary builtin string dependency into interface runtime support.These helpers are part of runtime interface support and should not depend on builtin string machinery by default.
This PR restores
v_typeof_interface_*tochar *. Call sites that really need a Vstringnow convert locally instead of pushing builtin string semantics into the helper itself.