Conversation
This comment has been minimized.
This comment has been minimized.
|
Some of these files show every line as different. Is this due to CR/LF? |
ryzhyk
left a comment
There was a problem hiding this comment.
There's a bunch of test failures. Some of them are probably caused by full disks on CI machines. Those should now be fixed. Others probably just require changing reference test outputs due to the use of a different hashing function.
I think most of the maps that use FNV today can be regular default HashMaps. I mostly used FNV to ensure deterministic iteration order. This is necessary e.g., when building dataflow graphs to make sure that each DD worker ends up with the same operator id assignment. In most other cases there's no reason for non-standard hasher.
| const XX_SEED1: u64 = 0x23b691a751d0e108; | ||
| const XX_SEED2: u64 = 0x20b09801dce5ff84; | ||
|
|
||
| #[inline] |
There was a problem hiding this comment.
why don't we trust the compiler with all this inlining?
There was a problem hiding this comment.
We do, however this makes the functions viable for cross-crate inlining

numfrom the dependency treefnvandtwox-hashand replaced with a single dependence onxxhash-rust, it has zero dependencies and is very lighttimefor all generated crates, this reduced the dependency tree a good bitDDVal/DDValueinnards