Skip to content

Commit 16b7558

Browse files
authored
Deactivate some thin_replica_server_test.cpp cases (#2647)
This commit deactivates certain test cases in thin-replica-server/test/thin_replica_server_test.cpp known to be unstable. This is intended to be a temporary measure in order to prevent these failures from blocking other merges, especially others intended to improve stability. The intention is to reactivate these test cases in the near future once a better fix for them can be provided.
1 parent 15153e8 commit 16b7558

File tree

1 file changed

+18
-6
lines changed

1 file changed

+18
-6
lines changed

thin-replica-server/test/thin_replica_server_test.cpp

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1296,7 +1296,9 @@ TEST(thin_replica_server_test, SubscribeToPrivateEventGroupUpdatesWithGap) {
12961296
EXPECT_EQ(state_machine.numEventGroupsReceived(), total_event_groups);
12971297
}
12981298

1299-
TEST(thin_replica_server_test, SubscribeToPrivateEventGroupUpdatesWithGapTwoClients) {
1299+
// Disabled due to instability in order to unblock master for other fixes to improve its stability.
1300+
// TODO (Alex): Develop a propper fix and re-enable this test.
1301+
TEST(thin_replica_server_test, DISABLED_SubscribeToPrivateEventGroupUpdatesWithGapTwoClients) {
13001302
// Initialize storage and live update queue
13011303
FakeStorage storage(generateEventGroupMap(1, kLastEventGroupId, EventGroupType::PrivateEventGroupsOnly, kClientId1));
13021304
auto client2_egs = generateEventGroupMap(
@@ -1427,7 +1429,9 @@ TEST(thin_replica_server_test, SubscribeToPublicEventGroupUpdatesWithGap) {
14271429
EXPECT_EQ(state_machine.numEventGroupsReceived(), total_event_groups);
14281430
}
14291431

1430-
TEST(thin_replica_server_test, SubscribeToPublicEventGroupUpdatesWithGapTwoClients) {
1432+
// Disabled due to instability in order to unblock master for other fixes to improve its stability.
1433+
// TODO (Alex): Develop a propper fix and re-enable this test.
1434+
TEST(thin_replica_server_test, DISABLED_SubscribeToPublicEventGroupUpdatesWithGapTwoClients) {
14311435
// Initialize storage and live update queue with public event groups and private event groups for kClientId2
14321436
// Initialize storage and live update queue
14331437
FakeStorage storage(generateEventGroupMap(1, kLastEventGroupId, EventGroupType::PublicEventGroupsOnly));
@@ -1557,7 +1561,9 @@ TEST(thin_replica_server_test, SubscribeToPublicAndPrivateEventGroupUpdatesWithG
15571561
EXPECT_EQ(state_machine.numEventGroupsReceived(), total_event_groups);
15581562
}
15591563

1560-
TEST(thin_replica_server_test, SubscribeToPublicAndPrivateEventGroupUpdatesWithGapTwoClients) {
1564+
// Disabled due to instability in order to unblock master for other fixes to improve its stability.
1565+
// TODO (Alex): Develop a propper fix and re-enable this test.
1566+
TEST(thin_replica_server_test, DISABLED_SubscribeToPublicAndPrivateEventGroupUpdatesWithGapTwoClients) {
15611567
// Initialize storage and live update queue
15621568
FakeStorage storage(
15631569
generateEventGroupMap(1, kLastEventGroupId, EventGroupType::PublicAndPrivateEventGroups, kClientId1));
@@ -2245,7 +2251,9 @@ TEST(thin_replica_server_test, SubscribeToPrivateEventGroupUpdateHashesWithGap)
22452251
EXPECT_EQ(state_machine.numEventGroupsReceived(), total_event_groups);
22462252
}
22472253

2248-
TEST(thin_replica_server_test, SubscribeToPrivateEventGroupUpdateHashesWithGapTwoClients) {
2254+
// Disabled due to instability in order to unblock master for other fixes to improve its stability.
2255+
// TODO (Alex): Develop a propper fix and re-enable this test.
2256+
TEST(thin_replica_server_test, DISABLED_SubscribeToPrivateEventGroupUpdateHashesWithGapTwoClients) {
22492257
// Initialize storage and live update queue
22502258
FakeStorage storage(generateEventGroupMap(1, kLastEventGroupId, EventGroupType::PrivateEventGroupsOnly, kClientId1));
22512259
auto client2_egs = generateEventGroupMap(
@@ -2374,7 +2382,9 @@ TEST(thin_replica_server_test, SubscribeToPublicEventGroupUpdateHashesWithGap) {
23742382
EXPECT_EQ(state_machine.numEventGroupsReceived(), total_event_groups);
23752383
}
23762384

2377-
TEST(thin_replica_server_test, SubscribeToPublicEventGroupUpdateHashesWithGapTwoClients) {
2385+
// Disabled due to instability in order to unblock master for other fixes to improve its stability.
2386+
// TODO (Alex): Develop a propper fix and re-enable this test.
2387+
TEST(thin_replica_server_test, DISABLED_SubscribeToPublicEventGroupUpdateHashesWithGapTwoClients) {
23782388
// Initialize storage and live update queue
23792389
FakeStorage storage(generateEventGroupMap(1, kLastEventGroupId, EventGroupType::PublicEventGroupsOnly));
23802390
auto client2_egs = generateEventGroupMap(
@@ -2503,7 +2513,9 @@ TEST(thin_replica_server_test, SubscribeToPublicAndPrivateEventGroupUpdateHashes
25032513
EXPECT_EQ(state_machine.numEventGroupsReceived(), total_event_groups);
25042514
}
25052515

2506-
TEST(thin_replica_server_test, SubscribeToPublicAndPrivateEventGroupUpdateHashesWithGapTwoClients) {
2516+
// Disabled due to instability in order to unblock master for other fixes to improve its stability.
2517+
// TODO (Alex): Develop a propper fix and re-enable this test.
2518+
TEST(thin_replica_server_test, DISABLED_SubscribeToPublicAndPrivateEventGroupUpdateHashesWithGapTwoClients) {
25072519
// Initialize storage and live update queue
25082520
FakeStorage storage(
25092521
generateEventGroupMap(1, kLastEventGroupId, EventGroupType::PublicAndPrivateEventGroups, kClientId1));

0 commit comments

Comments
 (0)