Deactivate some thin_replica_server_test.cpp cases#2647
Merged
teoparvanov merged 1 commit intovmware:masterfrom May 20, 2022
Merged
Conversation
This commit deactivates certain test cases in thin-replica-server/test/thin_replica_server_test.cpp known to be unstable. This is intended to be a temporary measure in order to prevent these failures from blocking other merges, especially others intended to improve stability. The intention is to reactivate these test cases in the near future once a better fix for them can be provided.
mdarade
pushed a commit
to mdarade/concord-bft
that referenced
this pull request
Jun 9, 2022
This commit deactivates certain test cases in thin-replica-server/test/thin_replica_server_test.cpp known to be unstable. This is intended to be a temporary measure in order to prevent these failures from blocking other merges, especially others intended to improve stability. The intention is to reactivate these test cases in the near future once a better fix for them can be provided.
cloudnoize
pushed a commit
to cloudnoize/concord-bft
that referenced
this pull request
Jun 28, 2022
This commit deactivates certain test cases in thin-replica-server/test/thin_replica_server_test.cpp known to be unstable. This is intended to be a temporary measure in order to prevent these failures from blocking other merges, especially others intended to improve stability. The intention is to reactivate these test cases in the near future once a better fix for them can be provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit deactivates certain test cases in
thin-replica-server/test/thin_replica_server_test.cppknown to be unstable. This is intended to be a temporary measure in order to prevent these failures from blocking other merges, especially others intended to improve stability. The intention is to reactivate these test cases in the near future once a better fix for them can be provided.Several test cases with names of the form
SubscribeTo*EventGroupUpdate*WithGapTwoClientshave been observed to fail intermittently onmaster. These failures have been observed to be significantly more common for builds withDCMAKE_BUILD_TYPE=DEBUG. These failures are interfering with the ability of developers to merge changes tomaster, including other changes intended to stabilize the branch.I have tried building with these changes and with
DCMAKE_BUILD_TYPE=DEBUGand running thethin_replica_server_testsuite built fromthin-replica-server/test/thin_replica_server_test.cpp. This suite has not failed since I reached the current set of deactivated test cases included in this PR, and I have run the suite with these changes and theDEBUGbuild at least several dozen times (I wanted to have a script run it at least a couple hundred times, but decided I'd probably run the tests enough times after a couple hours with no failures). I've also tried running the suite with a build with the default parameters (i.e. without explicitly providingDCMAKE_BUILD_TYPE=DEBUG) with these changes 32 times, and all of them passed with no failures.